782739 - mouse wheel zoom is lost after tab switch

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Timothy Nikkel (:tnikkel)]

Hold ctrl and rotate the mouse wheel to change zoom. Change tabs. Return on the original tab. The zoom change is lost for me.

I bisected this down to the patches for bug 719320.

Comment 1

[Alice0775 White]

I can reproduce the problem on Windows7 too.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120814030521

Comment 2

[Alice0775 White]

In http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-fullZoom.js#89 ,
It is necessary to adapt preferences name to the latest.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Alice0775 White from comment #2)
> In
> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-
> fullZoom.js#89 ,
> It is necessary to adapt preferences name to the latest.

Ah, failed to catch such code by searching "mousewheel.".

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=7aa024811555

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Hmm, this feature doesn't work with SpecialPowers.setFullZoom(). I think that when zoom in or out is performed, Gecko should dispatch a custom event and browser should listen it. But this patch is enough for now.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0ca290ec99c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0ca290ec99c