782815 - passing 'int *' to parameter of type 'unsigned int *' in setsockopt()

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P2)

Comment 1

[Jan Beich]

Attachment: Darwin/FreeBSD use socklen_t

ptio.c:1155:26: warning: passing 'int *' to parameter of type 'socklen_t *' (aka 'unsigned int *') converts between pointers to integer types with different sign [-Wpointer-sign]
                    &on, &optlen) == 0) {
                         ^~~~~~~
/usr/include/sys/socket.h:617:72: note: passing argument to parameter here
int     getsockopt(int, int, int, void * __restrict, socklen_t * __restrict);
                                                                           ^

Comment 2

[Wan-Teh Chang]

Comment on attachment 651910 [details] [diff] [review]
Darwin/FreeBSD use socklen_t

r=wtc. Thanks you for the patch. (I've had the same patch in
my source tree for a long time but never got around to
submitting it.) This patch was also submitted by Mikhail Teterin
in bug 527006 before.

Patch checked in on the NSPR trunk (NSPR 4.9.5).

Checking in ptio.c;
/cvsroot/mozilla/nsprpub/pr/src/pthreads/ptio.c,v  <--  ptio.c
new revision: 3.120; previous revision: 3.119
done