Closed
Bug 782824
Opened 12 years ago
Closed 11 years ago
Tests don't run when a module that dne is required (fennec)
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: jsantell)
Details
Attachments
(1 file)
when I require('xyz'); in my tests, then no tests are run, and no error message is displayed even with the -v option.
Expected:
An error message.
|
Reporter | |
Updated•12 years ago
|
OS: All → Android
Priority: -- → P1
|
Assignee | |
Comment 1•11 years ago
|
||
This seems to be erroring for me now -- Erik, can you confirm?
Flags: needinfo?(evold)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jsantell
|
|
Assignee | |
Comment 3•11 years ago
|
||
Added tests for this use case, passes in both FF/Fennec -- also switched to new test format
Attachment #793065 -
Flags: review?(evold)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Reimplemented the stacktrace tests for this, all passing
Flags: needinfo?(evold)
|
|
Reporter | |
Comment 5•11 years ago
|
||
Comment on attachment 793065 [details]
GH PR 1213
Nice!
Attachment #793065 -
Flags: review?(evold) → review+
|
|
Reporter | |
Updated•11 years ago
|
Flags: needinfo?(evold)
|
||
Comment 6•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/4771061cd6a123c887b3ba6fe10f661df67b88e8 Bug 782824 tests for modules that do not exist https://github.com/mozilla/addon-sdk/commit/43fc24f6884b862acd2e9bf2334054310d4df74e Merge pull request #1213 from jsantell/782824-tests-for-dne-modules Fix Bug 782824 tests for modules that do not exist, r=@erikvold
|
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•