Closed Bug 782825 Opened 12 years ago Closed 12 years ago

Disable bug 716014 for Firefox 15

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox15 + fixed

People

(Reporter: billm, Assigned: billm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 719114 comment 35 has more discussion of this. I'm uncertain whether this would reduce crash volume. However, I think the risk of the doing extra compartment GCs probably outweighs the rewards, which I think are mostly for people with many tabs open.
Attachment #651921 - Flags: review?(bugs)
Attachment #651921 - Flags: review?(bugs) → review+
Comment on attachment 651921 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 716014
User impact if declined: Possible increase in GC crashes.
Testing completed (on m-c, etc.): On m-c and aurora.
Risk to taking this patch (and alternatives if risky): Low, since this was disabled through part of aurora.
String or UUID changes made by this patch: None
Attachment #651921 - Flags: approval-mozilla-beta?
Attachment #651921 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to Bill McCloskey (:billm) from comment #2)
> https://hg.mozilla.org/releases/mozilla-beta/rev/65cd4f678ab0

Do we want to do the same for Beta 16?
(In reply to Alex Keybl [:akeybl] from comment #3)
> (In reply to Bill McCloskey (:billm) from comment #2)
> > https://hg.mozilla.org/releases/mozilla-beta/rev/65cd4f678ab0
> 
> Do we want to do the same for Beta 16?

It's already disabled in everything beyond 15.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: