Closed
Bug 782916
Opened 12 years ago
Closed 12 years ago
Do not compare nsresult to noErr
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
noErr is (apparently?) an OSStatus. It doesn't make sense to compare to an nsresult.
Attachment #652064 -
Flags: review?
|
|
Assignee | |
Updated•12 years ago
|
Attachment #652064 -
Flags: review? → review?(smontagu)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 652064 [details] [diff] [review] Patch Review of attachment 652064 [details] [diff] [review]: ----------------------------------------------------------------- r=me, but for some reason the dropdown won't let me actually set r+
|
|
||
Updated•12 years ago
|
Attachment #652064 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Green try: https://tbpl.mozilla.org/?tree=Try&rev=8d6b61bf89ac https://hg.mozilla.org/integration/mozilla-inbound/rev/19ec214f806c
Flags: in-testsuite-
|
||
Comment 4•12 years ago
|
||
Backed out for Android builds failures: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=19ec214f806c https://hg.mozilla.org/integration/mozilla-inbound/rev/22ce0a41fe21
|
|
||
Comment 5•12 years ago
|
||
Sorry, was looking at the wrong push. Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/d1ae1dae0fa1
|
||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d1ae1dae0fa1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•