783284 - Rename {winLastCreation, winLastWrite, winLastAccess}Time -> Date

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

For uniformity, we should rename winLastCreationTime et al to winLastCreationDate.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Renaming *Time to *Date

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 652458 [details] [diff] [review]
Renaming *Time to *Date

Review of attachment 652458 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/osfile/osfile_win_front.jsm
@@ +611,3 @@
>           let date = FILETIME_to_Date(this._ftCreationTime);
> +         delete this.winCreationDate;
> +         Object.defineProperty(this, "winCreationDate", {value: date});

For my own edification, why are we doing this delete/defineProperty dance?  This doesn't appear to buy anything save garbage generation, and some quick Googling doesn't turn up this pattern.  I thought the whole point of getters was that you could compute things dynamically.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Does the following reply to your question?
https://bug766194.bugzilla.mozilla.org/attachment.cgi?id=641495

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to David Rajchenbach Teller [:Yoric] from comment #3)
> Does the following reply to your question?
> https://bug766194.bugzilla.mozilla.org/attachment.cgi?id=641495

Oh my.  That's...awful.  I see the idiom now, but...*whistles*.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

In js-ctypes based stuff, I have started using this idiom everywhere, because calling a C function from JS is expensive, non-JIT-able, and also requires some gc-ing.

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Attachment: Renaming *Time to *Date

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=e01235322203

https://hg.mozilla.org/integration/mozilla-inbound/rev/15cdfa85ed10

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/15cdfa85ed10