783429 - Allow me to log in/log out

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[krupa raj[:krupa]]

We should allow users to Log out. Settings is probably a nice place to have this fetaure.

Comment 1

[krupa raj[:krupa]]

We should also allow users to log in.

Comment 2

[Maria Sandberg [:mushi]]

(In reply to krupa raj 82[:krupa] from comment #0)
> We should allow users to Log out. Settings is probably a nice place to have
> this fetaure.

This will depend on how the details on identity and payments shake out. It might be the case that there will be no log in/log out. Happy to talk about it more if and when we decide to go that way.

Comment 3

[Andrew Williamson [:eviljeff]]

(In reply to Maria Sandberg [:mushi] from comment #2)
> (In reply to krupa raj 82[:krupa] from comment #0)
> > We should allow users to Log out. Settings is probably a nice place to have
> > this fetaure.
> 
> This will depend on how the details on identity and payments shake out. It
> might be the case that there will be no log in/log out. Happy to talk about
> it more if and when we decide to go that way.

Users with extra privileges absolutely need to be able to log in and out.  (And by extension everyone)

Comment 4

[Wil Clouser [:clouserw]]

(In reply to Andrew Williamson [:eviljeff] from comment #3)
> (In reply to Maria Sandberg [:mushi] from comment #2)
> > (In reply to krupa raj 82[:krupa] from comment #0)
> > > We should allow users to Log out. Settings is probably a nice place to have
> > > this fetaure.
> > 
> > This will depend on how the details on identity and payments shake out. It
> > might be the case that there will be no log in/log out. Happy to talk about
> > it more if and when we decide to go that way.
> 
> Users with extra privileges absolutely need to be able to log in and out. 
> (And by extension everyone)

Yes, we need this.  Putting under settings is fine for the short term.

Comment 5

[Maria Sandberg [:mushi]]

The reason why I am being hesitant about this is that we don't know how sign in will work yet. (Unless there is new information from Dan Mills since last week that I haven't heard). 

We might end up in a situation where users on B2G sign in with their phone number and we do not have a password connected to it. In that case all a sign out / sign in button would do would be to toggle back and forth - not a very good experience and more confusing than useful. If you still want to go ahead and implement things for B2G before we know more, just be aware that these details are not yet finalized :)

Comment 6

[Christopher Van Wiemeersch [:cvan]]

(In reply to Maria Sandberg [:mushi] from comment #5)
> The reason why I am being hesitant about this is that we don't know how sign
> in will work yet. (Unless there is new information from Dan Mills since last
> week that I haven't heard). 

Authentication on desktop is still through Persona - and on B2G it's still through Persona for today (though that's of course changing). So yeah for now we still need people to log in for reviewing/submitting/approving (and hopefully purchasing soon!) apps.

Comment 7

[Andrew Williamson [:eviljeff]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #6)
> Authentication on desktop is still through Persona - and on B2G it's still
> through Persona for today (though that's of course changing). 

On non-B2G mobile (Android) its through Persona also.

Comment 8

[Davor Spasovski [:spasovski]]

done: https://github.com/mozilla/zamboni/commit/da4b035

Comment 9

[krupa raj[:krupa]]

Log in/Log out works, yay!

verified at https://marketplace-dev.allizom.org/settings