Closed
Bug 783654
Opened 12 years ago
Closed 12 years ago
Rename ERROR in TransportLayer::State enum
Categories
(Core :: WebRTC: Networking, defect)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: ted, Assigned: jesup)
Details
(Whiteboard: [WebRTC], [blocking-webrtc-] [qa-])
Attachments
(1 file)
|
18.63 KB,
patch
|
ekr
:
review+
|
Details | Diff | Splinter Review |
Windows header files #define ERROR, which make using that as an enum value a pain in the ass. We should rename this value.
|
||
Updated•12 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc-]
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → rjesup
|
|
Assignee | |
Comment 1•12 years ago
|
||
This applies against the webrtc.org -> alder merge I'm getting ready to commit
|
|
Assignee | |
Updated•12 years ago
|
Attachment #664954 -
Flags: review?(ekr)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 664954 [details] [diff] [review] Change State enum in TransportLayer to TS_FOO to avoid Windows "ERROR" macro Review of attachment 664954 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #664954 -
Flags: review?(ekr) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Landed in 8a9fbec09693 on alder on 9/17/2012
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-] [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•