Closed
Bug 783663
Opened 12 years ago
Closed 12 years ago
ReadPixelsIntoImageSurface pulls from bound framebuffer, not the screen
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(1 file, 1 obsolete file)
11.35 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
ReadPixelsIntoImageSurface is just a wrapper that calls ReadPixels into a gfxImageSurface. While this is fine, it is used in Layers as if it always reads from the screen, which is not the case.
Assignee | ||
Comment 1•12 years ago
|
||
Actually, it looks like this is only the case on OGL Layers.
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Comment 3•12 years ago
|
||
Accidentally built this on top of another patch. Here's the rebased version.
Attachment #652886 -
Attachment is obsolete: true
Attachment #652886 -
Flags: review?(bgirard)
Attachment #652888 -
Flags: review?(bgirard)
Comment 4•12 years ago
|
||
Comment on attachment 652888 [details] [diff] [review] Now without cruft from patches it was on top of... Review of attachment 652888 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/opengl/CanvasLayerOGL.cpp @@ +208,5 @@ > GetTempSurface(size, gfxASurface::ImageFormatARGB32); > > + updatedAreaImageSurface->Flush(); > + mCanvasGLContext->ReadScreenIntoImageSurface(updatedAreaImageSurface); > + updatedAreaImageSurface->MarkDirty(); Good catch with the flush/markdirty.
Attachment #652888 -
Flags: review?(bgirard) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [rplus]
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/68f2ac456dbc
Whiteboard: [rplus]
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/68f2ac456dbc
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•