Closed
Bug 783700
Opened 12 years ago
Closed 12 years ago
nsColumnSetFrame::BuildDisplayList should use nsFrameList::Enumerator to enumerate children
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
1.36 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
We should be using the (relatively new) nsFrameList::Enumerator class for frame-list-iteration where possible, instead of directly walking a frame list. nsColumnSetFrame::BuildDisplayList currently walks directly over its child list. Filing this bug on switching it to using nsFrameList::Enumerator.
Assignee | ||
Comment 1•12 years ago
|
||
FWIW, I just cribbed the Enumerator "for" loop line from here: http://mxr.mozilla.org/mozilla-central/source/layout/tables/nsTableRowGroupFrame.cpp#43
Attachment #652955 -
Flags: review?(dbaron)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
I'm curious whether you guys think the intent was that we use nsFrameList::Enumerator this way. (I originally suggested it to dholbert, but then he pointed out that code like this wasn't converted when nsFrameList::Enumerator was introduced.)
Comment 3•12 years ago
|
||
Yes, I think the intent was to convert frame list loops in this way. I certainly do it whenever I get the chance. Please r- me if you see I don't :-)
Comment on attachment 652955 [details] [diff] [review] fix r=dbaron
Attachment #652955 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/53951ff066a6
OS: Linux → All
Hardware: x86_64 → All
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/53951ff066a6
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•