Closed
Bug 783863
Opened 12 years ago
Closed 12 years ago
ArchiveInputStream::Tell incorrectly uses mStatus as an nsresult
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
749 bytes,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Bug 781153 added this: NS_IMETHODIMP ArchiveInputStream::Tell(PRInt64 *aResult) { if (NS_FAILED(mStatus)) return mStatus; LL_UI2L(*aResult, mData.cursor); return NS_OK; } mStatus is defined as: enum { NotStarted, Started, Done } mStatus; So NS_FAILED() will always return false here.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #653157 -
Flags: review?(jst)
Comment 2•12 years ago
|
||
Comment on attachment 653157 [details] [diff] [review] Patch This is fine with me, but I'm going to defer the actual review to Andrea who wrote this code.
Attachment #653157 -
Flags: review?(jst) → review?(amarchesini)
Comment 3•12 years ago
|
||
Comment on attachment 653157 [details] [diff] [review] Patch right!
Attachment #653157 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/26da3bdbf618
Flags: in-testsuite-
OS: Linux → All
Hardware: x86 → All
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/26da3bdbf618
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•