784050 - Remove code to remove stylesheets and style tags from document in readability.js

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Lucas Rocha (:lucasr)]

We don't use the original document in reader. No need to care about stylesheets in the original document.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: No need to remove stylesheets and style tags in Readability.js

Comment 2

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/650fedd0f930

Comment 3

[Lucas Rocha (:lucasr)]

I should have only removed the part that removes stylesheets from the document. Some pages add style tags inside the body and is causing problems to the candidate score calculation. I'll put this code back.

Comment 4

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/ae40b8512ddf

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/650fedd0f930
https://hg.mozilla.org/mozilla-central/rev/ae40b8512ddf

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 653399 [details] [diff] [review]
No need to remove stylesheets and style tags in Readability.js

[Approval Request Comment]
User impact if declined: Unnecessary overhead when checking readability of pages.
Testing completed (on m-c, etc.): Landed in m-c, no regressions.
Risk to taking this patch (and alternatives if risky): Very low, just removes unnecessary code.
String or UUID changes made by this patch: None.

Comment 7

[Lucas Rocha (:lucasr)]

Pushed to mozilla-aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/c80a6ec01250

Comment 8

[Cristian Nicolae (:xti)]

The code was cleaned up on the latest Nightly, Aurora and Beta builds. Closing bug as verified fixed.

--
Device: Galaxy Note
OS: Android 4.0.4