784260 - [Azure] DrawTargetD2D::CreateBrushForPattern should be able to deal with surfaces from other Azure backends

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nick Cameron [:nrc]]

Crashes with a null pointer exception in D2D code.

Comment 1

[Nick Cameron [:nrc]]

Attachment: test case

You need to have D3D layers and D2D enabled, then prefer the Cairo Azure backend, then load the test case (you'll need some local file called hippo.jpg, or change to some other image name, doesn't seem to work with remote images though).

Expected: a 100x100 part of the image at the top left, and the whole image on the right

Actual result: crashes

Comment 2

[Nick Cameron [:nrc]]

Attachment: patch

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 653659 [details] [diff] [review]
patch

Looks fine to me, keep in mind this is not encouraged practice :).

Comment 4

[Nick Cameron [:nrc]]

(In reply to Bas Schouten (:bas) from comment #3)
> Comment on attachment 653659 [details] [diff] [review]
> patch
> 
> Looks fine to me, keep in mind this is not encouraged practice :).

Having different backends for content and canvas? Or passing surfaces from one backend to another? Because the latter will always happen if we allow the former.

Comment 5

[Nick Cameron [:nrc]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=1fd087447bb8

Comment 6

[Nick Cameron [:nrc]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=ca3a3ff0af73

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ca3a3ff0af73