Closed
Bug 784746
Opened 12 years ago
Closed 12 years ago
Contacts API: optimize debug statements
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: gwagner, Assigned: gwagner)
References
Details
Attachments
(1 file)
30.40 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → anygregor
Assignee | ||
Comment 1•12 years ago
|
||
Currently we create lots of garbage because we use let DEBUG = 0; if (DEBUG) debug = function (s) { dump("-*- ContactManager: " + s + "\n"); } else debug = function (s) {} debug(...) I want to change it to if (DEBUG) debug()
Assignee | ||
Comment 2•12 years ago
|
||
Does the perf needle move with this patch?
Assignee | ||
Updated•12 years ago
|
Attachment #654314 -
Flags: review?(bent.mozilla)
Comment on attachment 654314 [details] [diff] [review] patch Review of attachment 654314 [details] [diff] [review]: ----------------------------------------------------------------- rs=me!
Attachment #654314 -
Flags: review+
Updated•12 years ago
|
Attachment #654314 -
Flags: review?(bent.mozilla)
Comment 5•12 years ago
|
||
Comment on attachment 654314 [details] [diff] [review] patch Review of attachment 654314 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/contacts/ContactManager.js @@ +4,5 @@ > > "use strict"; > > +const DEBUG = false; > +debug = function (s) { dump("-*- ContactManager: " + s + "\n"); } Missing variable definition for `debug`. Either let debug = ... or function debug(...) ... (I suggest the latter.)
Assignee | ||
Comment 6•12 years ago
|
||
Fixed the variable definition. https://hg.mozilla.org/integration/mozilla-inbound/rev/3f340329e85b
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Andreas Gal :gal from comment #7) > What about comment 3? 500 contacts take now 1.5 sec with the UI Test -> Get all contacts. So from 9sec to 1.5sec.
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3f340329e85b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Updated•12 years ago
|
blocking-basecamp: ? → +
You need to log in
before you can comment on or make changes to this bug.
Description
•