784894 - put NPOTB tools/utilities in js/src/devtools

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: mv

I talked about this with sfink a long time ago: it would be nice to keep the not-part-of-the-build random helper files in a subdirectory of js/src.  (This is part of the general modularization plan (https://wiki.mozilla.org/JS_engine_modularization) which wants to generally move things out of js/src.)

/moz/mi/js/src $ ls -1 devtools
ETWProvider.man
gc
gnuplot
javascript-trace.d
jint
sharkctl.cpp
sharkctl.h
vprof

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 654481 [details] [diff] [review]
mv

Sorry for the review delay. This patch will break --enable-dtrace and --enable-etw, at least, because it doesn't update the Makefile.in targets. I can fix up --enable-dtrace easily enough. It'll take me a little longer to get to --enable-etw; it would be fine to land without doing that, though.

Comment 2

[Luke Wagner [:luke]]

Oh yes, sorry about that, I'll post a new patch with dtrace fixed.

Comment 3

[Luke Wagner [:luke]]

Attachment: mv

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 655227 [details] [diff] [review]
mv

Review of attachment 655227 [details] [diff] [review]:
-----------------------------------------------------------------

I tried out dtrace and it still works. Good enough for me.

Comment 5

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f24546b76f3e

Comment 6

[Luke Wagner [:luke]]

Followup fix for OS X:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b3af36ea9cf

(I thought I had try'd this on all platforms.)

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f24546b76f3e
https://hg.mozilla.org/mozilla-central/rev/7b3af36ea9cf

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 655227 [details] [diff] [review]
mv

Review of attachment 655227 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ -130,5 @@
>  		TestingFunctions.cpp \
>  		LifoAlloc.cpp \
>  		Eval.cpp \
>  		MapObject.cpp \
> -		MemoryMetrics.cpp \

Why?

Comment 9

[Luke Wagner [:luke]]

(In reply to :Ms2ger from comment #8)

Because every other .cpp in js/src starts with 'js', it looked out of place.

Comment 10

[Nicholas Nethercote [inactive]]

> Because every other .cpp in js/src starts with 'js', it looked out of place.

js/src/public/MemoryMetrics.h now looks out of place...

Comment 11

[Luke Wagner [:luke]]

Not locally:

/moz/mi/js $ ls public/
HashTable.h  LegacyIntTypes.h  MemoryMetrics.h  TemplateLib.h  Utility.h  Vector.h

To fix the difference between js/src and all the new dirs, we could mass-rename jsfoo.h to Foo.h...