784975 - New App Menu button hard to see on dark themes

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Greg ( Hank1 )]

Attachment: Dark Solid Persona - New Menu Button.JPG

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120822030558

Steps to reproduce:

installed a dark Persona 


Actual results:

installed a Dark Solid Persona and totally covers up the New Menu button making it hard to see


Expected results:

the New Menu button should be visible with a Dark Persona installed

Comment 1

[Greg ( Hank1 )]

Attachment: without a Persona,

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Richard, can you look at this?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: patch

This patch changes the toolbar-icons to the inverted (white) icons we use on Aero Glass tabbar-toolbar.

Comment 4

[Richard Marti (:Paenglab)]

We have only inverted icons for the main window. Should I open a Bug to add inverted icons in AB and Compozer?

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 654653 [details] [diff] [review]
patch

This fixes the problem when people choose a dark theme, but not when they go into high-contrast mode, so ui-r-.

Having said that, the code itself seems fine, so r=me.

Thanks,
Blake.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 654653 [details] [diff] [review]
patch

So, as noted in IRC, the other buttons are also not nicely visible: https://dl.dropbox.com/u/23792533/screenshots/High-contrast.png and we're fixing that in bug 608792, and this fixes the problem as stated in the bug, so ui-r=me too.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/26a39d376821