785146 - mozprofile should set the version for permissions.sqlite

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

We currently don't give a schema version to the permissions.sqlite
db :

https://github.com/mozilla/mozbase/blob/master/mozprofile/mozprofile/permissions.py#L231

We should: https://bugzilla.mozilla.org/show_bug.cgi?id=784875

ABICT, this should be version 3:

https://bugzilla.mozilla.org/show_bug.cgi?id=784875#c1

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: add schema version

Not sure if there's a better way.

Comment 2

[Jeff Hammel]

Comment on attachment 709129 [details] [diff] [review]
add schema version

I ain't a SQLite expert but I would assume this is sufficient.  Bonus points for writing a test that fails without this patch and passes with.

Comment 3

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: also add test

Comment 4

[Jeff Hammel]

And, sure enough, fails without the code change, passes with :)  Awesome job, mihnea!

Comment 5

[Jeff Hammel]

pushed: https://github.com/mozilla/mozbase/commit/d9e769d5bcdf5420e92fdf3b43f766e9c9a13520

...and another bug bites the dust

Comment 6

[Mihnea Dobrescu-Balaur (:mihneadb)]

(In reply to Jeff Hammel [:jhammel] from comment #4)
> And, sure enough, fails without the code change, passes with :)  Awesome
> job, mihnea!

Yes, I checked. Thanks!