Closed
Bug 785156
Opened 12 years ago
Closed 11 years ago
Lock icon should toggle site security popup
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: wesj, Assigned: stully)
References
Details
(Whiteboard: [mentor=wesj][lang=java])
Attachments
(1 file, 2 obsolete files)
1.16 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
Tappping the lock icon should toggle the site security popup, but right now it just shows it. When you tap on the lock icon while the popup is showing, Android hides the popup on touchdown. Then, when the click fires on the lock icon, we show it again, making it appear and disappear. I hate it. Fixing it was a bit ugly. I had to use a touchlistener and basically set a boolean so that we'd ignore the click. To make that a bit prettier, I used some gestureListener stuff.
Reporter | ||
Comment 1•12 years ago
|
||
Comment on attachment 654709 [details] [diff] [review] Patch I tried to be generic here and it didn't entirely work, but I kinda think its good to keep around in case we can remove it some day.
Attachment #654709 -
Flags: review?(margaret.leibovic)
Comment 2•12 years ago
|
||
Comment on attachment 654709 [details] [diff] [review] Patch Unfortunately, you'll have to rebase because bug 771380 just landed.
Attachment #654709 -
Attachment is patch: true
Updated•12 years ago
|
Assignee: nobody → wjohnston
Comment 3•12 years ago
|
||
Comment on attachment 654709 [details] [diff] [review] Patch I'm just going to r- this because it needs to be updated.
Attachment #654709 -
Flags: review?(margaret.leibovic) → review-
Reporter | ||
Updated•11 years ago
|
Whiteboard: [mentor=wesj][lang=java]
Reporter | ||
Updated•11 years ago
|
Assignee: wjohnston → nobody
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → stully
Assignee | ||
Comment 5•11 years ago
|
||
Make the SiteIdentityPopup focusable at the suggestion of sirram. This makes the SiteIdentityPopup capture the click event so it is not passed down to the favicon/padlock icon which would have displayed the popup again.
Attachment #753435 -
Flags: review?(wjohnston)
Reporter | ||
Comment 6•11 years ago
|
||
Comment on attachment 753435 [details] [diff] [review] Make SiteIdentityPopup focusable Review of attachment 753435 [details] [diff] [review]: ----------------------------------------------------------------- Lets add a comment about why we're doing this too. List this bug number as well so that people can refer back. Something like: // Make this focuscable so that we tapping on the favicon won't reshow the popup. See bug 785156.
Attachment #753435 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Added comment
Attachment #654709 -
Attachment is obsolete: true
Attachment #753435 -
Attachment is obsolete: true
Attachment #753855 -
Flags: review?(wjohnston)
Reporter | ||
Updated•11 years ago
|
Attachment #753855 -
Flags: review?(wjohnston) → review+
Reporter | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3869dc547459
Keywords: checkin-needed
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3869dc547459
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•