Closed
Bug 785244
Opened 12 years ago
Closed 12 years ago
Featured apps should show up if no time range specified
Categories
(Marketplace Graveyard :: Consumer Pages, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
2012-08-30
People
(Reporter: krupa.mozbugs, Assigned: ashort)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
161.27 KB,
image/png
|
Details |
steps to reproduce: 1. Have country = Brazil and load https://marketplace-dev.allizom.org/ 2. Notice that there are no featured apps. expected behavior: If there are no region-specific featured apps, we show apps featured for Worldwide observed behavior: We don't show any featured apps. See screenshot
Comment 1•12 years ago
|
||
This is unrelated to regional features/fallbacks. This is a regression from https://github.com/mozilla/zamboni/commit/44000f6c#L4R413 Worldwide: http://f.cl.ly/items/150w0A1H432I31412S2t/Screen%20shot%202012-08-29%20at%208.45.33%20AM.png United States: http://f.cl.ly/items/1s0C2n0S1f1e1v44470F/Screen%20shot%202012-08-29%20at%208.45.20%20AM.png We're now always (incorrectly) requiring a time range to be specified for each feature. We should instead just respect a time range if one is specified, otherwise show features indefinitely.
Assignee: nobody → ashort
Keywords: regression
Summary: Backfill from Worldwide when a region has no featured apps → Featured apps should show up if no time range specified
Target Milestone: --- → 2012-08-30
Assignee | ||
Comment 2•12 years ago
|
||
http://github.com/mozilla/zamboni/commit/79367f0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 3•12 years ago
|
||
featured apps are still not showing up
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 4•12 years ago
|
||
(In reply to krupa raj 82[:krupa] from comment #3) > featured apps are still not showing up Well, that's because every app that is featured has a time range that has expired: http://cl.ly/image/2Q101s0V0I2X But on a very related note, removing a start date or end date also not work.
Assignee | ||
Comment 5•12 years ago
|
||
https://github.com/mozilla/zamboni/commit/860ac7ab44143e9b3a7fa50431f2e9709fcefcf2 https://github.com/mozilla/zamboni/commit/0274a5f0d51814f1ef12fadc316a86e95eef9c3f
Assignee | ||
Updated•12 years ago
|
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment 6•12 years ago
|
||
Verified as fixed. Screencast for country=Brazil : http://screencast.com/t/gebdPtGoRwb
Status: RESOLVED → VERIFIED
Comment 7•12 years ago
|
||
Verified as fixed. Screencast for country=Brazil : http://screencast.com/t/gebdPtGoRwb
You need to log in
before you can comment on or make changes to this bug.
Description
•