785510 - [AccessFu] only instantiate a11y engine on AccessFu._enable()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Some globals have us instantiating a11y early (understatement).

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Add accessible retreival service to utils, and remove it as global from modules.

Didn't test this much. But I think this is good, at least before uplift.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 655162 [details] [diff] [review]
Add accessible retreival service to utils, and remove it as global from modules.

Review of attachment 655162 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't apply and test this patch as I'm assuming you did. I assume grepping for global gAccRetrieval declarations (you deleted the 3 I found), and usage now results in the empty set.

I'm assuming there is no sign of engine instantiation anymore.

Thanks for jumping on this (yoikes).

r=me

::: accessible/src/jsat/Utils.jsm
@@ +22,5 @@
>  
> +  get AccRetrieval() {
> +    if (!this._AccRetrieval)
> +      this._AccRetrieval = Cc['@mozilla.org/accessibleRetrieval;1'].
> +          getService(Ci.nsIAccessibleRetrieval);

nit: Since this spans two lines I'd like to see {}'s or a space before the return.

Comment 3

[Eitan Isaacson [:eeejay]]

Addressed nits

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6192cb67e8c

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/d6192cb67e8c