785622 - Some files are always rebuilt during incremental builds because of dangling .pp files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Since bug 766975 landed, people have had dangling .pp files in the .deps directories in the objdir, and as a result, their incremental build have been rebuilding some files even when rebuilding them was not required. This results in extra time waiting for builds.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Only include .pp files corresponding to files we do build

The cl.py changes are due to the fact that we were actually not storing the .pp file in the right directory when the object file name contains a path (such as when building libjpeg). This makes the behaviour match that of unix builds.

I checked that all the .pp files we generate during a clobber build are included this way, and media/libvpx and js/xpconnect/src are the only places where we have custom-generated files that generate .pp files that aren't included in the variables I added, so they are now in an extra variable.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2e464e9524b

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c2e464e9524b