785659 - Get rid of calIRecurrenceDateSet

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This interface isn't used often and items are usually parsed into multiple EXDATE properties anyway. This will help me transition to using the jsical library in the future.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Matthew Mecca [:mmecca]]

Comment on attachment 655366 [details] [diff] [review]
Fix - v1

Review of attachment 655366 [details] [diff] [review]:
-----------------------------------------------------------------

r=mmecca

::: calendar/providers/storage/calStorageCalendar.js
@@ +1814,4 @@
>          item.setProperty("LAST-MODIFIED", savedLastModifiedTime);
>      },
>  
> +    addRecurrenceItemsFromRow: function cSC_getRecurrenceItemFromRow(row, item) {

I'd suggest cSC_addRecurrenceItemsFromRow for consistency

Comment 3

[Matthew Mecca [:mmecca]]

(In reply to Matthew Mecca [:mmecca] from comment #2)
> > +    addRecurrenceItemsFromRow: function cSC_getRecurrenceItemFromRow(row, item) {
> 
> I'd suggest cSC_addRecurrenceItemsFromRow for consistency

Nevermind, I see the name changes in Bug 785733

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 0e6bba2e7c54