785731 - Rotating from portrait to landscape with tab menu open: Tabs partly hidden

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android 20120826, Android 4.1.1 (stock), Google Nexus S

When rotating from portrait to landscape mode with the tab menu open, the tab list will have 100% height (normally it hasn't) and only a part of it will show the tabs and be scrollable, the rest is a dark grey area.

Steps to reproduce:
1. Open at least 3 tabs.
2. Get into portrait mode.
3. Open tab menu.
4. Rotate to landscape mode.

Comment 1

[Aaron Train [:aaronmt]]

I think this is a regression. Sriram?

Comment 2

[Aaron Train [:aaronmt]]

Another STR :: new profile, launch Fennec (08/27), and rotate to landscape

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Last good: 20120821
First bad: 20120822

Comment 4

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5228384d4da8&tochange=228414e09533

Nothing stands out really. Bug 779321 maybe?

Comment 5

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ca2c1aa1acbc#l1.42 <-- This is the reason. Will patch it soon.

Comment 6

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

The animation check is not needed when it's not a sidebar. The layout is full-screen, and would actually go back and forth when sync is enabled.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 655703 [details] [diff] [review]
Patch

Review of attachment 655703 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The patch this bug fixes (bug 779321) was uplifted into 16 so please make sure this gets uplifted as well.

Comment 10

[Aaron Train [:aaronmt]]

Seems like according to bug 763406 comment #4; this is an issue across all branches.

Comment 11

[Scoobidiver (away)]

Comment 3 and 16.0b1 being affected are inconsistent.

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Scoobidiver from comment #11)
> Comment 3 and 16.0b1 being affected are inconsistent.

16 should be affected. The patch that caused the problem (bug 779321) was uplifted in Aurora when Aurora was still 16.

Comment 13

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29e1983201a5

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/29e1983201a5

Comment 15

[Cristian Nicolae (:xti)]

This issue is not longer reproducible on the latest Nightly. Closing bug as verified fixed on:

Firefox 18.0a1 (2012-09-12)
Device: Galaxy Note
OS: Android 4.0.4