Closed
Bug 785828
Opened 12 years ago
Closed 12 years ago
Ensure that libxul.so is loaded lazily
Categories
(Toolkit Graveyard :: OS.File, defect)
Toolkit Graveyard
OS.File
Tracking
(firefox17 fixed)
RESOLVED
FIXED
mozilla18
Tracking | Status | |
---|---|---|
firefox17 | --- | fixed |
People
(Reporter: Yoric, Assigned: Yoric)
Details
Attachments
(2 files, 1 obsolete file)
6.04 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
6.15 KB,
patch
|
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Here we go.
Assignee: nobody → dteller
Attachment #655551 -
Flags: review?(nfroyd)
Comment 2•12 years ago
|
||
Comment on attachment 655551 [details] [diff] [review] Load libxul.so lazily Review of attachment 655551 [details] [diff] [review]: ----------------------------------------------------------------- IIUC, we don't have to modify back-end specific things because they don't interact with libxul, correct?
Attachment #655551 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Indeed, at the moment, nothing interacts with libxul besides the string-related functions patched here.
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #655551 -
Attachment is obsolete: true
Attachment #655957 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•12 years ago
|
||
For reference, loading libxul.so eagerly causes all sorts of "interesting" errors during the construction of the startup cache. I tend to believe that this is actually a design error in the startup cache, but loading libxul.so lazily makes sense, in addition of postponing the time at which we will need to fix the startup cache construction.
Comment 6•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=ce0eb243566d
Comment 7•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #6) > https://tbpl.mozilla.org/?tree=Try&rev=ce0eb243566d Green on Try. https://hg.mozilla.org/integration/mozilla-inbound/rev/04d13cf166ab
Flags: in-testsuite-
Keywords: checkin-needed
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/04d13cf166ab
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Try run at https://tbpl.mozilla.org/?tree=Try&rev=099466ea69fc Porting this patch to Aurora makes it safer to port the patch in bug 787334 and that one fixes "make package" for XULRunner. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: None Testing completed (on m-c, etc.): Try is running. Risk to taking this patch (and alternatives if risky): Build problems. String or UUID changes made by this patch: None
Attachment #661829 -
Flags: approval-mozilla-aurora?
Comment 10•12 years ago
|
||
Comment on attachment 661829 [details] [diff] [review] backport to aurora Looks like it will be obvious if this doesn't work on Aurora, approving.
Attachment #661829 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•12 years ago
|
status-firefox17:
--- → fixed
Updated•11 months ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•