786068 - make JS_EnterCrossCompartmentCall infallible

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: patch

There isn't any need to malloc storage when there is only one meaningful word that needs to be saved.  Also rename to JS_(Enter|Leave)Compartment (since I am auditing all the call-sites anyway).

Comment 1

[Luke Wagner [:luke]]

Attachment: patch

Now with comments

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 655799 [details] [diff] [review]
patch

Review of attachment 655799 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, that is so much nicer.

I'm a little surprised at how few uses there were.

::: js/src/jsdbgapi.h
@@ +12,5 @@
>   */
>  #include "jsapi.h"
>  #include "jsprvtd.h"
>  
> +#if defined(DEBUG) && defined(__cplusplus)

This makes js_DumpBacktrace(cx) DEBUG-only and compiled as a C++ symbol. Previously it was unconditional and compiled as a C symbol. Was that change intentional?

Comment 3

[Luke Wagner [:luke]]

(In reply to Steve Fink [:sfink] from comment #2)
Oops, no.  I don't really think it matters, but I might as well put it back.

Comment 4

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d65863fbb129

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d65863fbb129