786219 - Lack for pdfjs/content/web/images/toolbarButton-fullscreen.png

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

At Bug 784718, we update pdf.js to 0.4.11.
But its commit lack for pdfjs/content/web/images/toolbarButton-fullscreen.png.

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch

This patch is for mozilla-central 18.
And also the patch is needed to approval-aurora 17.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 655960 [details] [diff] [review]
patch

r=whatever

Comment 3

[:Gavin Sharp [email: [e-mail]]]

What practical effects does this image being missing have?

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #3)
> What practical effects does this image being missing have?

Not showing the full-screen icon in PDF viewer.
It should be shown next to the "Download" icon.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/acb866bc42c2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 655960 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 784718
User impact if declined: Not showing the full-screen icon in PDF viewer next to the download icon.
Testing completed (on m-c, etc.): Local testing. On inbound.
Risk to taking this patch (and alternatives if risky): Very little.
String or UUID changes made by this patch: None.

Comment 7

[Alex Keybl [:akeybl]]

PDF.js was disabled by default in bug 786012 for FF16/17. What's the motivation for fixing this on Aurora given that?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 655960 [details] [diff] [review]
patch

Some people might want to enable it for testing, or something. Doesn't really hurt to take it for consistency, IMO, since there's no risk.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cb69436c3056

Comment 10

[Alex Keybl [:akeybl]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #8)
> Some people might want to enable it for testing, or something. Doesn't
> really hurt to take it for consistency, IMO, since there's no risk.

We normally don't take fixes for features that are disabled by default, and enabled through about:config. Tinkerers can always get their fix on Nightly. It's mostly a matter of consistency in triage and landings.

Understood that a file addition is obviously low risk though.

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/acb866bc42c2