786313 - Automatic prioritization of interfaces for nICEr

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Eric Rescorla (:ekr)]

Currently nICEr has fixed prioritization for each interface. This chokes if unknown interface names are provided. At minimum we need a way to automatically prioritize new interfaces. Better would be to interrogate the interface and try to automatically prioritize everything.

Comment 1

[Eric Rescorla (:ekr)]

Fixed in: : http://hg.mozilla.org/projects/alder/rev/b1a6785f8e0c

r=me

Comment 3

[Eric Rescorla (:ekr)]

The code in nricectx.cpp probably still needs some cleanup

Comment 4

[Maire Reavy [:mreavy]]

Byron - if there's more cleanup needed, please file a bug for it and set the priority/rank/etc; we should likely close this bug.

Comment 5

[Byron Campen [:bwc]]

I'm not exactly sure what cleanup we're talking about here. I can try to figure out.

Comment 6

[Eric Rescorla (:ekr)]

This is done, though it could be improved. Right now we use a sort of ad hoc order on Mac and Windows (some combination of defined names and auto-assignment). We should extend nrinterfaceprioritizer to these platforms (which means exposing interface types on them).

Comment 7

[Eric Rescorla (:ekr)]

Looking at this code, the net net is that we have semi-sensible defaults for the common interface names on Mac and probably just do order of encountering on windows (because the defaults are only for mac names).

The thing we're missing to make the prioritizer work on those platforms is exporting the interface properties that it uses.

Comment 8

[Eric Rescorla (:ekr)]

See also:
https://bugzilla.mozilla.org/show_bug.cgi?id=895790
and:
https://bugzilla.mozilla.org/show_bug.cgi?id=895793

Comment 9

[Byron Campen [:bwc]]

Ok, let's go ahead and close this since we have the follow-up bugs.