Closed Bug 786603 Opened 12 years ago Closed 12 years ago

Readability.js has some coding style inconsistencies

Categories

(Firefox for Android Graveyard :: Reader View, defect, P5)

Product:
Firefox for Android Graveyard
Component:
Reader View
Platform:
All
Android
Type:
defect

Tracking

(firefox18 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 18
Tracking Flags:
Tracking Status
firefox18 --- verified

People

(Reporter: lucasr, Assigned: ande1474)

Details

Attachments

(1 file, 1 obsolete file)

Patch file for my changes.
3.38 KB, patch
lucasr
: review+
jaws
: feedback+
Details | Diff | Splinter Review 
For instance, one-line if's shouldn't have {}'s
Priority: -- → P5
Assignee: nobody → ande1474
Status: NEW → ASSIGNED
Attached patch file to be fixed (obsolete) — — Splinter Review 
fixed coding style to better match the standards used throughout the rest of the file.
Attachment #659383 - Attachment is patch: true
Attachment #659383 - Attachment mime type: application/octet-stream → text/plain
Michael, can you generate a diff of your changes and upload your diff to this bug? Ask for help in #introduction if you are confused.

        Attachment #659746 -
        Flags: review?(lucasr.at.mozilla)

        Attachment #659746 -
        Flags: review?(jaws)

        Attachment #659383 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 659746 [details] [diff] [review]
Patch file for my changes.

This looks good to me. I marked this feedback+ (and not review+), because I'd still like Lucas to take a look at the patch to make sure everything is accounted for.

Tip: When uploading a file, mark 'obsolete' the older versions of the patch and check the 'patch' checkbox if the attachment is a patch for the bug.

        Attachment #659746 -
        Attachment is patch: true

        Attachment #659746 -
        Flags: review?(jaws) → feedback+

    
  

        Attachment #659746 -
        Flags: review?(lucasr.at.mozilla) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/af6c294d2bc7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18

    
    

    
  
The corrections were applied on the latest Nightly. Closing bug as verified fixed on:

Firefox 18.0a1 (2012-09-19)
Device: Galaxy Note
OS: Android 4.0.4
Status: RESOLVED → VERIFIED

          status-firefox18:
          --- → verified

    
  
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: