787093 - "profile" link in share panel opens in the current tab

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Ian Bicking (:ianbicking)]

When clicking on some links, like the self-profile link, the page opens in the current tab.  In other cases the links open in a new tab.  I'm guessing the social provider handles this (perhaps with target=_blank), but I think all links should be forced to open in new tabs, unless perhaps there is a tab already open with that exact URL (like a homepage), in which case selecting that tab would be excellent.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to Ian Bicking (:ianb) from comment #0)
> but I think all links should be forced to open in new tabs, unless perhaps there is
> a tab already open with that exact URL (like a homepage), in which case
> selecting that tab would be excellent.

This is tricky to get right - some providers might have functionality that depends on link navigation not being redirected to work properly. For app-tabs, we use a heuristic (try to redirect untargeted links to "external sites" to other tabs), and we've extended that to social panels, but that obviously doesn't catch all cases. The simplest approach is to just have the providers target their links correctly, but it's not clear to me yet whether that's the right tradeoff.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: openintab.patch

From what I can see, only the profile link in the menu is opening in the current tab.  This is also the link that is part of chrome, rather than a link in content.  This patch fixes opening the profile (from the provider menu) in a new tab.  This is more consistent with how we are opening new tabs from content.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 657416 [details] [diff] [review]
openintab.patch

Oh! I guess I missed that part of comment 0 :) Makes sense!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a86d43be76f
https://hg.mozilla.org/releases/mozilla-aurora/rev/3a8b3255f42b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a86d43be76f

Comment 6

[u279076]

Verified fixed with latest Firefox 17.0a2 and 18.0a1.