Closed Bug 787443 Opened 12 years ago Closed 12 years ago

CmdCmd.jsm and CmdCookie.jsm include Console.jsm with the wrong url

Categories

(DevTools :: General, defect)

14 Branch
defect
Not set
normal

Tracking

(firefox17 fixed)

RESOLVED FIXED
Firefox 18
Tracking Status
firefox17 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

It's resource://gre/modules/devtools/Console.jsm, not resource:///modules/devtools/Console.jsm
Comment on attachment 657303 [details] [diff] [review]
CmdCmd.jsm and CmdCookie.jsm include Console.jsm with the wrong url

Review of attachment 657303 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I'll add this to my list of things to land.
Attachment #657303 - Flags: review+
(In reply to Joe Walker [:jwalker] from comment #2)
> Thanks. I'll add this to my list of things to land.

That's okay, i'll land it with other things i need to land.
Comment on attachment 657303 [details] [diff] [review]
CmdCmd.jsm and CmdCookie.jsm include Console.jsm with the wrong url

[Approval Request Comment]
User impact if declined: This breaks Firefox when built as a xulrunner application
Risk to taking this patch (and alternatives if risky): Low. On mozilla builds, we're effectively changing an url to another url that resolves to the exact same location.
String or UUID changes made by this patch: None
Attachment #657303 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/d6b20244c71b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #657303 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [qa-]
Is there a reason for the qa-?
qa- simply means this bug is not a first priority for verification by QA. We don't have time nor resources to verify all bugs so we have to prioritize. Apologies for not clarifying earlier. 

If you think this bug is critical to be verified before we ship Firefox 17 please make a justification.

Thanks.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: