787654 - Zune and Royale have wrong window color with draw in title bar

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

From bug 755793 comment 49:

> Created attachment 657201 [details]
> mail.tabs.drawInTitlebar enabled with Zune Desktop Theme
> 
> Just wanted to note that drawing in titlebar causes unreadable visuals
> with the official Zune theme [1].
> 
> [1]: http://go.microsoft.com/fwlink/?LinkID=75078

It look I didn't used the official themes (there are a lot of them around). I haven't found a official DL link for Royale but the one I now used looks most "official".

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

Patch setting individual colors instead using the system colors which don't match the border colors.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: screenshot

Screenshot for easier UI-review. On top Zune active window, second with inactive window, third Royale activ and the last inactive.

Comment 3

[Andreas Nilsson (:andreasn)]

Comment on attachment 657553 [details] [diff] [review]
patch

Looks good!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/156e66fb3269

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 657553 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 755793
User impact if declined: only visual, hard readable tabs
Risk to taking this patch (and alternatives if risky): no high risk, it's only color change through CSS.

If approval + I'll add a patch which applies cleanly.

Comment 6

[Richard Marti (:Paenglab)]

This patch applies on comm-aurora. So no need for a special patch.

Comment 7

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/comm-aurora/rev/120aa51ba5d3