78806 - CertViewer: sizing problems

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Bob Lord]

There are several sizing problems with the CertViewer.  These problems inlclude:

-The window expands to fit the widest field in the General pane (usually the
Subject Name).  That's almost always way too large.

-The window is not resizable

Comment 1

[Javier Delgadillo]

Attachment: Patch to fix bug.

Comment 2

[Javier Delgadillo]

thayes, ddrinan: one of you please review.

Comment 3

[Ian McGreer]

r=mcgreer with a caveat on the unneccessary string copy

Comment 4

[Javier Delgadillo]

Attachment: Patch v2 with mcgreers comments incorporated

Comment 5

[Javier Delgadillo]

Asking blizzard for super review

Comment 6

[Christopher Blizzard (:blizzard)]

+  if (redraw) {
+    rowsToDelete = 0-CountNumberOfVisibleRows(mASN1Object);
+  }

That looks odd.  Can you comment that please?

+  nsXPIDLString temp;
+  CERTRDN **lastRdn;
+  lastRdn = rdns;
+  /* find last RDN */
+  lastRdn = rdns;
+  while (*lastRdn) lastRdn++;
+  lastRdn--;

Can you throw some vertical whitespace in there in between the variable
declarations and the actual code?  Stealth code!  And comment the while()
lasRdn-- magic please?

Other than that sr=blizzard

Comment 7

[Javier Delgadillo]

I've made the modifications requested by blizzard and am sending this bug to
[e-mail] for check-in approval.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

There are a lot of cases where inline style appears to be used for formatting. 
In almost every case there are classes in the skin that give the precise amount 
of padding and margin appropriate for specific uses. 

I'd like to see a screenshot of the effect of these patches. It seems there's a 
bunch of other UI details that need to be seen to. Mostly, these details are 
small alignment fixes and a matter of using the right class in the right 
situation. I'd be happy to perform a thorough examination of this chrome over 
the phone, and make recommendations as to what changes need to be made to make 
things fit, size, and align, as they should. Please let me know if you're 
interested. 

Comment 9

[Javier Delgadillo]

Attachment: Patch after incorporating ben's comments

Comment 10

[Javier Delgadillo]

Attachment: Details panel w/ latest patch.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

(s)r=[e-mail] for the latest set of changes. 

Comment 12

[Javier Delgadillo]

Attachment: General panel after patch.

Comment 13

[Christopher Blizzard (:blizzard)]

a=blizzard for 0.9.1

Comment 14

[Javier Delgadillo]

fix has been checked in. (a=blizzard)

Comment 15

[Javier Delgadillo]

Mark fixed for real this time.

Comment 16

[John Unruh]

Verified fixed.