788234 - Starting in Firefox 17, long notification bars force-resize the window

Status: NEW

(Firefox :: Theme, defect)

Description

[Stephan Sokolow]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120903063249

Steps to reproduce:

Click a URL that triggers a long doorhanger that can't word-wrap.

The easiest way I know to generate one is to:
1. Install NoScript
2. Embed a localhost URL with a very long query parameter in a non-local HTML file
3. Click it


Actual results:

In Aurora 17, it forcibly resizes the window to be something on the order of 10,000 pixels wide. (An estimate I arrived at because it's roughly 5 times as wide as my 2560x1024 dual-monitor desktop)


Expected results:

It should have forced word-wrap on the doorhanger's contents. Reactions to content should never resize the Firefox window. (I'm operating on the assumption that explicit window resizing by Javascript has been disallowed in Preferences)

However, I'd be OK with restoring the Firefox 16 behaviour where, if the doorhanger is too wide for the window, Firefox' chrome stretches and gets truncated rather than forcing a resize of the system-level window.

Comment 1

[Vlad [QA]]

Can you provide some example?
Thanks

Comment 2

[Stephan Sokolow]

(In reply to Vlad [QA] from comment #1)
> Can you provide some example?
> Thanks

In what form? A screenshot?

Comment 3

[[:Aleksej]]

I guess that’s not a doorhanger; maybe it’s called a notification bar.

Comment 4

[[:Aleksej]]

Compare: bug 691849.

Comment 5

[Stephan Sokolow]

(In reply to Aleksej [:Aleksej] from comment #4)
> Compare: bug 691849.

Exact same behaviour I got in Firefox 16 and below except that the bar NoScript creates is at the top of the content region rather than the bottom. (So the screenshot that bug provides is a reasonable example of what older versions did)

Firefox 17 could be said to fix that problem, but it does it by, instead, force-resizing the OS-level browser window to fit non-wrapping content that, in my case, is about five times as wide as my desktop. (Which I consider worse)

Comment 6

[Stephan Sokolow]

I just noticed that, now that Aurora channel has me on build 20120913180634, the browser window undoes its self-resizing when the problematic notification is hidden. (eg. by navigating or closing the tab)

Still not ideal, but at least I don't have to struggle to manually undo a resize operation that could leave the window 5 or 6 times as wide as my desktop.

Comment 7

[Stephan Sokolow]

(In reply to Stephan Sokolow from comment #6)
> I just noticed that, now that Aurora channel has me on build 20120913180634,
> the browser window undoes its self-resizing when the problematic
> notification is hidden. (eg. by navigating or closing the tab)
> 
> Still not ideal, but at least I don't have to struggle to manually undo a
> resize operation that could leave the window 5 or 6 times as wide as my
> desktop.

Actually, I just realized that may just be how my window manager (Openbox) handles maximized windows.

The app I'm using to test is a prototype with no logout button, so I'll try to remember to test with Firefox unmaximized next time I restart the browser.

Comment 8

[Stephan Sokolow]

Worse than I suspected. With Firefox not maximized, not only does it resize the window and leave it that way, it also moves the window.

(It was in the middle of my left-hand monitor. When I clicked the huge link NoScript's ABE blocked, the notification moved the window to fill my right-hand monitor.)

Comment 9

[Stephan Sokolow]

Attachment: Minimal test case including instructions

Here. Maybe the problem will be more clear if I offer a simple test case that'll demonstrate the problem with two clicks. (Plus whatever time it takes you to install NoScript)

Comment 10

[Stephan Sokolow]

Attachment: Same testcase uploaded with another attempt at setting text/html mimetype

Either I wasn't paying attention to Bugzilla has a bug in the mimetype selector.

Comment 11

[Stephan Sokolow]

Attachment: Testcase uploaded with mimetype auto-detect

Ok. Bugzilla has a bug in the "select from list" mimetype selector.

Comment 12

[Daniel Holbert [:dholbert]]

I can reproduce. I suspect it might be a NoScript bug, though. (It might be noscript's responsibility to make that content area be "overflow:hidden" or "text-overflow:ellipsis" or something.)

CC'ing NoScript author Giorgio Maone.

Comment 13

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Here's a screenshot of the (crazy-wide) window that the testcase produces for me (w/ Nightly, on Ubuntu 12.10 using Gnome Shell)

Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20130129 Firefox/21.0

Comment 14

[Giorgio Maone [:ma1]]

(In reply to Daniel Holbert [:dholbert] from comment #12)
>(It might be
> noscript's responsibility to make that content area be "overflow:hidden" or
> "text-overflow:ellipsis" or something.)

It's not the first time I try to tackle this problem, and unfortunately it's not that simple. 

Setting overflow:hidden, text-overflow:ellipsis or both on either the <notification> element itself or its <description> XBL descendent has no effect.

I even tried to force wrapping by inserting a non-visible space ("\u200B") every 20 characters, but this technique, which works fine for doorhangers and prompt box, doesn't affect notifications. In facts, in NSA++ (on Android) I switched to doorhangers and this is not an issue anymore, but switching on the desktop would be problematic yet.

Comment 15

[Kanchan Kumari QA]

Hello Reporter, I tried to duplicate the problem on FF 17 on Ubuntu 32 bit and I was able to see the problem. However, when I tried it on the latest released versions of FF (43.0.4) and the latest nightly build 46.0a1, I found that problem was fixed. Below is one of the FF version on which I found your issue to be working fine.

Name 	Firefox
Version 	46.0a1
Build ID 	20160113030208
Update Channel 	nightly
User Agent 	Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0

Can you please upgrade your FF version to the latest released version if you have not done so and provide your confirmation that this issue stands fixed now? Thank You!

Comment 16

[Stephan Sokolow]

Attachment: New screenshot

Well, it doesn't force-resize the window anymore, but it does force the browser chrome to exceed the window dimensions in an "overflow: hidden" sort of way unless you manually resize it up to what it used to force.

(Note the top-right corner of that window. The tab bar and address bar are much wider than the window and get clipped down.

Comment 17

[Kanchan Kumari QA]

I was focusing more towards the original issue in which you stressed more towards the window force-resize problem. Agreed that it is no more an issue but it does force firefox to exceed the window dimensions in an "overflow: hidden" sort of way even with the newer versions. Changing the status of the defect to "New".

Comment 18

[Ryan VanderMeulen [:RyanVM]]

This feels like a browser UI issue, not a core issue.