788346 - Fix the built-in error console and expose it in the app bar

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

I wanted to see the error console while doing some testing on Metro.  I noticed that Metro has a built-in button to display the desktop error console in a separate window, but it didn't work on the tablet.  The old XUL Fennec console is still there, but it was accidentally broken by bug 747789 which changed a variable from "ConsoleView" to "ConsolePanelView" without changing all the references.

This patch fixes that, and exposes the built-in console panel in the app bar when devtools.errorconsole.enabled is true.

Comment 1

[Frank Yan (:fryn)]

Using Fennec as product is somewhat misleading.
We have been using Firefox as the product and Windows 8 Metro as the platform for Windows 8 Metro bugs.

I'll review this soon. :)

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

I accidentally reversed the logic for when to show the JS shell button.

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/projects/elm/rev/76eae491f55a

Comment 4

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.