Closed Bug 788489 Opened 12 years ago Closed 12 years ago

nightly mozconfigs in mozilla-aurora/beta should not have --disable-profiling

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Version:
16 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox16 fixed, firefox17 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox16 --- fixed
firefox17 --- fixed

People

(Reporter: catlee, Assigned: ehsan.akhgari)

References

Details

Attachments

(2 files)

Aurora patch
3.72 KB, patch
catlee
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Beta patch
3.72 KB, patch
catlee
: review+
lsblakk
: approval-mozilla-beta+
Details | Diff | Splinter Review 
As part of our pre-release tests, we compare the nightly and release mozconfigs for each platform under $product/config/mozconfigs. The check has been failing for beta builds because the nightly mozconfigs have --disable-profiling, and the release mozconfig doesn't have it. The check doesn't know which is the default, so it's safer to have both mozconfigs contain the same flag.

This probably affects aurora and central as well.
You can use `sed /enable-profiling/d` to delete lines, e.g.:

sed -i /enable-profiling/d browser/config/mozconfigs/linux32/nightly
Summary: release mozconfigs in mozilla-beta should have --disable-profiling → nightly mozconfigs in mozilla-aurora/beta should not have --disable-profiling
Attached patch Aurora patch — — Splinter Review 
Not sure if this requires approval, but here it goes.
Attachment #658934 - Flags: review?(catlee)
Attachment #658934 - Flags: approval-mozilla-aurora?
Attached patch Beta patch — — Splinter Review 

        Attachment #658935 -
        Flags: review?(catlee)

        Attachment #658935 -
        Flags: approval-mozilla-beta?

    
  

        Attachment #658934 -
        Flags: review?(catlee) → review+

    
  

        Attachment #658935 -
        Flags: review?(catlee) → review+

    
    

    
  
Comment 0 mentions this affects central as well. Is that just not a problem because "release" mozconfigs aren't used there?

    
    

    
  
(In reply to comment #5)
> Comment 0 mentions this affects central as well. Is that just not a problem
> because "release" mozconfigs aren't used there?

release mozconfigs don't have --enable-profiling in them.

        Attachment #658934 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

        Attachment #658935 -
        Flags: approval-mozilla-beta? → approval-mozilla-beta+
Component: Build Config → General
Product: Firefox → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: