789114 - Make B2G and Fennec browser actors inherit the extensibility API changes

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

The patch in bug 753401 allows add-ons to provide their own actors for the remote protocol. However this was tested and verified to work for desktop add-ons only, and B2G and Fennec add-ons need some more changes to work.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v1

Trying to minimize changes to B2G and Fennec actors. glandium can you verify that this patch works for you in both cases?

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 658924 [details] [diff] [review]
Patch v1

As said on irc, only tested on b2g, assuming the fennec part corresponds to the previous iteration (which, looking at the code, looks like is the case)

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v2

This is slightly better. If you can confirm it still works, I'll ask for reviews.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 659727 [details] [diff] [review]
Patch v2

It works for me on Fennec (haven't checked B2G)

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 659727 [details] [diff] [review]
Patch v2

This patch allows dynamically-added actors to be usable via the remote debugging protocol for Fennec and B2G. For B2G I'm not sure if add-ons will be allowed (perhaps provided by the vendor, like what we do with PDF.js in desktop?), but the API is still useful regardless. The changes are pretty straight-forward.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 659727 [details] [diff] [review]
Patch v2

The Fennec changes look fine

Comment 7

[Mihai Sucan [:msucan]]

Comment on attachment 659727 [details] [diff] [review]
Patch v2

Looks good.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/642f820edff8

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/642f820edff8