Closed
Bug 789338
Opened 12 years ago
Closed 11 years ago
[Metro] "Toggle tabs" buttons works with mouse only (not with touch)
Categories
(Firefox for Metro Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Whiteboard: [metro-preview][completed-elm])
Attachments
(1 file)
1.21 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
This button works with mouse clicks but not with taps. Simple fix.
Attachment #659051 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #659051 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 1•12 years ago
|
||
https://hg.mozilla.org/projects/elm/rev/093f67354fd6
Whiteboard: [metro-preview] → [metro-preview][completed-elm]
Comment 2•12 years ago
|
||
Jared implemented the onkeypress and onmousedown in bug 778340 for better responsiveness, but when we fixed mouse/tap events, that approach of course no longer worked for touch. I'm okay with leaving it as it is now. :)
Blocks: 778340
Comment 3•12 years ago
|
||
Could we have left my approach, added a oncommand handler, and had the onmousedown and onkeydown handlers call preventDefault?
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Jared Wein [:jaws] from comment #3) > Could we have left my approach, added a oncommand handler, and had the > onmousedown and onkeydown handlers call preventDefault? That sounds good; I can try that out next week (or I'm happy to review a patch).
Updated•12 years ago
|
Component: Toolbars → General
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk
Assignee | ||
Comment 5•11 years ago
|
||
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch. Sorry for the bugspam. Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•