789725 - "activate.bat" can not find python when installed in path with spaces on XP

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect, P3)

Description

[andershol]

I downloaded the SDK version 1.9, unzip'ed it and tried running activate.bat from a command prompt, and go the message "Warning: Failed to find Python installation directory", which is odd since I have both 2.6 and 2.7 installed.

The problem seems to be that python is installed in a path with spaces (i.e. "C:\Program Files\Python27") and the activate script removes spaces from the "PYTHONINSTALL" variable before testing it.

The script seems to work if the script is changed not to remove the spaces, but instead just quote the path, but I guess the space removal must be in there for a reason:

 rem Remove spaces.
-set PYTHONINSTALL=%PYTHONINSTALL: =%
-if exist %PYTHONINSTALL%\python.exe goto :EOF
+if exist "%PYTHONINSTALL%\python.exe" goto :EOF
 rem It may be a 32bit Python directory built from source, in which case the

Comment 2

[bulwersator]

Also on Windows 7.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: pull request, v1

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

can we wontfix this?  I'm voting +1 since we are not going to release a new cfx.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8530277 [details] [review]
pull request, v1

I'm going to r- since we aren't going to release a new version of cfx, Irakli can review if he wants to.

Comment 6

[bulwersator]

"we are not going to release a new cfx" Why not? Is it deprecated and replaced by something else?

Comment 7

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 8530277 [details] [review]
pull request, v1

As Erik has pointed out in previous comment, we are not going to release any new versions of cfx as our future plan is to uplift most functionality to firefox itself & expose cli interface via nodejs (this project lives under https://github.com/mozilla/jpm)

Given that no official release will be made for CFX any more I do not think there is much point in me reviewing this patch.

I'm Cc-ing Jeff who should be able to give a better idea how does the roadmap of tool switch looks like.

Comment 8

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to bulwersator from comment #6)
> "we are not going to release a new cfx" Why not? Is it deprecated and
> replaced by something else?

Yes, well, very nearly; the replacement is jpm:

https://github.com/mozilla/jpm

For tips on transitioning, see Erik's excellent blog post:

http://work.erikvold.com/jetpack/2014/08/07/cfx-to-jpm.html

I apologize if this comes as a surprise.