Closed Bug 789824 Opened 12 years ago Closed 12 years ago

Regression of min-/max-height on -moz-box containers

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18
Tracking Flags:
Tracking Status
firefox16 - ---
firefox17 + fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

Details

(Keywords: regression)

Attachments

(1 file)

fix + reftest
6.48 KB, patch
bzbarsky
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
      No description provided.
Comment on attachment 659591 [details] [diff] [review]
fix + reftest

r=me.  Sorry I missed this in bug 785754.  :(
Attachment #659591 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c14834c3ce2d
Flags: in-testsuite+
Target Milestone: --- → mozilla18
Comment on attachment 659591 [details] [diff] [review]
fix + reftest

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 776265
User impact if declined: minor layout error when using CSS min-/max-height on display:-moz-box elements (I'd expect that's used in XUL for the most part)
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch:  none
Attachment #659591 - Flags: approval-mozilla-beta?
Attachment #659591 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/c14834c3ce2d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 659591 [details] [diff] [review]
fix + reftest

We're backing out bug 716875 for Fx16, so this isn't needed there.
Attachment #659591 - Flags: approval-mozilla-beta?
Attachment #659591 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Taking off tracking 16 here then since the backout will be tracked in bug 716875.
tracking-firefox16: + → -
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: