789847 - Remove the usage of PR_CALLBACK from our tree

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[(no longer active)]

See <http://mxr.mozilla.org/mozilla-central/ident?i=PR_CALLBACK>.  PR_CALLBACK expands to nothing, and is useless.  We should just remove it.

Note that the patch here should not touch the NSPR or NSS code, bit we can remove PR_CALLBACK from everywhere else in the tree.

Comment 1

[Mozilla RelEng Bot]

Try run for df744b8ca6c2 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=df744b8ca6c2
Results (out of 6 total builds):
    exception: 6
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-df744b8ca6c2

Comment 2

[Isaac Aggrey [:isaac]]

Attachment: Remove PR_CALLBACK from tree

I modified a script similar to attachment 653946 [details] to remove PR_CALLBACK without touching the NSPR or NSS code as specified; this patch is the result of the script (will attach separately).

I also manually maintained code formatting where appropriate.

Comment 3

[Isaac Aggrey [:isaac]]

Attachment: Remove PR_CALLBACK from tree (correct formatting)

I caught an additional formatting issue a result of the patch.

Also, on extra try submissions (all cancelled in a few minutes):
* First one: An empty try that was a mistake.
* Second one: I'm not sure if it matters, but I thought I should probably get a review first on the patch before sending to try anyway.

Comment 4

[Isaac Aggrey [:isaac]]

Attachment: Remove PR_CALLBACK from tree (correct formatting)

I goofed again, this is the correct attachment.

Comment 5

[Mozilla RelEng Bot]

Try run for 994431c0baab is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=994431c0baab
Results (out of 6 total builds):
    exception: 6
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-994431c0baab

Comment 6

[Isaac Aggrey [:isaac]]

Attachment: Remove PR_CALLBACK from tree

My mistake, I should've double-checked MXR before posting my patch.

My script was missing PR_CALLBACKs at the end of lines, this patch should now cover all usage of PR_CALLBACKs in the tree, excluding NSPR and NSS code.

Comment 7

[Isaac Aggrey [:isaac]]

Attachment: Script to remove PR_CALLBACK

Comment 8

[Isaac Aggrey [:isaac]]

Attachment: Remove PR_CALLBACK from tree

I also should've made sure my patch message isn't a try command. It's really up for review now, I'm not touching it anymore! ;-)

Comment 9

[Isaac Aggrey [:isaac]]

It looks like a green try for my patch: https://tbpl.mozilla.org/?tree=Try&rev=4281a1110e36

Comment 10

[(no longer active)]

Comment on attachment 664539 [details] [diff] [review]
Remove PR_CALLBACK from tree

Looks great, thanks!

Comment 11

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b13571ca268d

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b13571ca268d