Closed
Bug 789849
Opened 12 years ago
Closed 12 years ago
Use PNG instead of TIFF for cursor/pointer resources
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file)
22.79 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
We currently ship a number of TIFF files for mouse pointers (cursors) types which are not supported by the base OS. OS X supports PNG for these, and it would be far more convenient to just use PNG instead of the terrible TIFF format. This patch is a mostly-mechanical result of me using Preview.app to export all the current TIFF images as PNG. I then ran them though pngcrush just for good measure. (Working though a weird compile-time issue ATM, but I think this patch works)
Assignee | ||
Updated•12 years ago
|
Attachment #659615 -
Attachment is patch: true
Assignee | ||
Comment 1•12 years ago
|
||
Webkit switched quite some time ago: https://bugs.webkit.org/show_bug.cgi?id=11291
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 659615 [details] [diff] [review] Patch v.0 Seems to work fine with the testcase in bug 784909. (Though till fuzzy in HiDPI mode, as expected)
Attachment #659615 -
Attachment description: Patch v.0 (WIP) → Patch v.0
Attachment #659615 -
Flags: review?(smichaud)
Assignee | ||
Comment 3•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=d09812c73407 Couple of weird errors on debug xpcshell (something about file permissions in some cache dir), but I _think_ it's not me.
Assignee | ||
Comment 4•12 years ago
|
||
(Bug 752243 I am now told)
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 659615 [details] [diff] [review] Patch v.0 Moving review, since Steven noted he's swamped with HiDPI plugin stuff.
Attachment #659615 -
Flags: review?(smichaud) → review?(joshmoz)
Attachment #659615 -
Flags: review?(joshmoz) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/767157026993
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/767157026993
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•12 years ago
|
Assignee: nobody → dolske
You need to log in
before you can comment on or make changes to this bug.
Description
•