Closed
Bug 789859
Opened 12 years ago
Closed 12 years ago
Toolbar notification icons don't close on second click.
Categories
(Firefox Graveyard :: SocialAPI, defect, P1)
Tracking
(firefox17 fixed)
RESOLVED
FIXED
Firefox 18
Tracking | Status | |
---|---|---|
firefox17 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
References
Details
(Whiteboard: [Fx17])
Attachments
(1 file)
807 bytes,
patch
|
jaws
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
* Click once in the toolbar notification area - notification opens * Click again in the same area: ** Expected: The notification area closes and stays closed. ** Actual: The notification area closes, then immediately re-opens. This is possibly Windows only.
Comment 1•12 years ago
|
||
I'm pretty sure (untested), that |consumeoutsideclicks="true"| needs to be set on the panel to fix this. See http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#359 and http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#271 for comparison. Mark, can you test this out?
Assignee | ||
Updated•12 years ago
|
Priority: -- → P1
Updated•12 years ago
|
Whiteboard: [Fx17]
Assignee | ||
Comment 3•12 years ago
|
||
As usual, Jaws is right on the money!
Assignee: nobody → mhammond
Attachment #660332 -
Flags: review?(jaws)
Updated•12 years ago
|
Attachment #660332 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/db504651197a
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/db504651197a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Updated•12 years ago
|
Attachment #660332 -
Flags: approval-mozilla-aurora+
Comment 6•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/0527322af7a6
status-firefox17:
--- → fixed
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•