790379 - add more profile labels for style change processing

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See bug 780341 and bug 779968 for background.

Looking at profiles for style change processing is somewhat confusing right now; the stuff currently inside the CSS::ProcessRestyles label is really two different things, recomputation of style data and then handling the resulting changes.

This patch adds two labels to split it into those major parts.  It's untested.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Add more profile labels for the separate parts of restyle processing. ()

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 660194 [details] [diff] [review]
Add more profile labels for the separate parts of restyle processing.  ()

rs=me

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/557733e500ca

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/557733e500ca

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: two more labels

Two more labels, to try to distinguish benefits we'd get from bug 780341 comment 30 (would help with the time inside FileRules) vs. benefits we'd get from bug 780341 comment 38 (would help with the time inside CalcStyleDifference).

With these labels, I'm a bit concerned that they're too far inside the loop and might influence the timing.  However, I *think* they're going to occur the same number of times in the cases we're looking at, since we won't actually end up with the same style context in any of the cases where we hit FileRules.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 660585 [details] [diff] [review]
two more labels

rs=me (rubberstamp because I don't know this code and am trusting you to put them in the right place.)  You're more than welcome to land any more labels you want to add as rs=me, too.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2172a4fab4c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f2172a4fab4c