Closed
Bug 790465
Opened 12 years ago
Closed 12 years ago
Refactor Marionette testrunner to make Gaia testing easier
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: jgriffin, Assigned: jgriffin)
References
Details
Attachments
(1 file, 2 obsolete files)
14.38 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
This patch does a couple of things: - it adds a console entry point for Marionette ("marionette") that allows you to run Marionette tests from anywhere; you don't need to be in the directory where runtests.py lives - it makes it possible to subclass the testrunner to provide a custom test class I've already tested that these changes are harmless to current automation, and that they work for the target use case; that is, I've created a GaiaTestClass which exposes some unique methods applicable to Gaia testing, and verified I could run tests with them independent of Marionette's pre-existing test classes. I'll submit the Gaia-related changes in a separate patch.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #660250 -
Flags: review?(mdas)
Assignee | ||
Comment 2•12 years ago
|
||
Realized I should have bumped the version here as well
Attachment #660251 -
Flags: review?(mdas)
Assignee | ||
Updated•12 years ago
|
Attachment #660250 -
Attachment is obsolete: true
Attachment #660250 -
Flags: review?(mdas)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → jgriffin
Comment 3•12 years ago
|
||
Comment on attachment 660251 [details] [diff] [review] Refactor Marionette testrunner to make it easier to write Gaia tests, Review of attachment 660251 [details] [diff] [review]: ----------------------------------------------------------------- This looks great, thanks! ::: testing/marionette/client/marionette/marionette_test.py @@ +52,1 @@ > def kill_gaia_app(self, url): We should probably remove this and kill_gaia_apps from the CommonTestCase class
Attachment #660251 -
Flags: review?(mdas) → review+
Comment 4•12 years ago
|
||
bug 787114 was created to deal with the gaia helper functions, but I think we can change that here and close this bug
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Malini Das [:mdas] from comment #4) > bug 787114 was created to deal with the gaia helper functions, but I think > we can change that here and close this bug I agree, I duped that bug and will remove those functions with this patch.
Assignee | ||
Comment 7•12 years ago
|
||
Updated patch to remove unneeded Gaia methods, pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=dc20b5313b8f
Assignee | ||
Updated•12 years ago
|
Attachment #660251 -
Attachment is obsolete: true
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 661383 [details] [diff] [review] Refactor Marionette testrunner to make it easier to write Gaia tests, Carrying r+ forward
Attachment #661383 -
Flags: review+
Assignee | ||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d96a5392ff4
Target Milestone: --- → mozilla18
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8d96a5392ff4
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•