Closed
Bug 790488
Opened 12 years ago
Closed 12 years ago
shareButton tests should check behaviour of multiple tabs
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(firefox17 fixed)
RESOLVED
FIXED
Firefox 18
Tracking | Status | |
---|---|---|
firefox17 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(1 file)
3.87 KB,
patch
|
jaws
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The share button tests should check a couple of multi-tab scenarios: * With 2 tabs on the same page and the share action taken on one of the tabs, that action if reflected when switching to the other tab. * With 1 tab opened and shared, then the tab closed and another tab to the same URL is opened, the share state is still reflected. The following patch is only to tests as it did all work as expected :)
Attachment #660276 -
Flags: review?(jaws)
Comment 1•12 years ago
|
||
Comment on attachment 660276 [details] [diff] [review] New tests Review of attachment 660276 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/browser_social_shareButton.js @@ +200,5 @@ > + } > + is(shareButton.hasAttribute("shared"), false, "Share button should not have 'shared' for the initial tab"); > + let tab1 = gBrowser.selectedTab = gBrowser.addTab(toShare); > + let tab1b = gBrowser.getBrowserForTab(tab1); > + nit: please remove these blank spaces.
Attachment #660276 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a63439012b3
Flags: in-testsuite+
OS: Windows 7 → All
Hardware: x86_64 → All
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4a63439012b3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Updated•12 years ago
|
Attachment #660276 -
Flags: approval-mozilla-aurora+
Updated•12 years ago
|
Assignee: nobody → mhammond
Comment 4•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/e7b0279a3f5d
status-firefox17:
--- → fixed
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•