790541 - B2G STK: Revise implementation of sendICCEnvelopeCommand

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In dom/system/gonk/ril_worker.js,
sendICCEnvelopeCommand only sends Envelope command with MENU_SELECTION,
as we're going to support other Envelope commands,
this function should be more generalized.

Comment 1

[Andrew Overholt [:overholt]]

Yoshi, is this a basecamp blocker?

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Yes, it's needed in Brazil.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 661112 [details] [diff] [review]
Patch

Hi, philikon
This is a quick patch for revising SEND_ENVELOPE_COMMMAND, 
would you help to review this ?

Thanks

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/488d7455150a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/488d7455150a