79106 - 1 pixel cracks visible in some xul widgets that use background images

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Skewer]

Procedure: Using the Modern theme, copy the below text into your URL bar
(assuming Bugzilla doesn't know well enough to make it a link):

javascript:alert(confirm("Foo"));

Expected: OK button is all in one piece.

Actual: Right side of OK button is broken off. Always reproducible with Modern
theme, does not occur with Classic theme.

Build: 20010505 Win98

Comment 1

[Blake Ross]

-> Themes

Comment 2

[timeless]

reporter: please attach a picture, thanks.

Comment 3

[Joe Hewitt (gone)]

Don't need a picture - this is a longstanding bug in layout.  My guess is, the
twips-to-pixels calculation is occasionally off by one pixel, leaving the
"crack" in the buttons where the background image is not painted.  This can also
be seen in the scrollbar thumbs in modern.

Comment 4

[Skewer]

Attachment: Confirm window with broken OK button

Comment 5

[Skewer]

BTW, I am getting this behavior in 16 and 32 bit color 800x600 resolution, and
my desktop has 15x15 twips per pixel.

Comment 6

[Joe Hewitt (gone)]

*** Bug 81445 has been marked as a duplicate of this bug. ***

Comment 7

[Joe Hewitt (gone)]

*** Bug 81474 has been marked as a duplicate of this bug. ***

Comment 8

[Joe Hewitt (gone)]

*** Bug 81459 has been marked as a duplicate of this bug. ***

Comment 9

[Skewer]

Keywording. Should this be -> Skinability?

Comment 10

[Skewer]

Nominating for moz0.9.1

Comment 11

[Skewer]

I haven't seen this problem in a while. Has anyone else?

Comment 12

[Joe Hewitt (gone)]

yes, it's still there

Comment 13

[Skewer]

Where is it happening now? I may need to update the testcase.

Comment 14

[karnaze (gone)]

Reassigning to savulov and moving to m0.9.3. Alex, I suspect that Hewitt's 
comments on 5/7/1 may be right. I have seen cases where blocks do not size 
frames on even pixel boundaries.

Comment 15

[Asko Tontti]

scrollbar thumb's rounding error is bug 56876.

Comment 16

[scalkins]

I see the pixel cracks in spell check on new modern on todays branch build Win32
2001-07-23-06 0.9.2. They show on the right side of the "Ignore All", "Edit" and
"Close" buttons

Comment 17

[laurel]

July23 commercial branch 0.9.2:  Search Mail/News Messages has the problem in
one of the criteria dropdowns.

Comment 18

[scalkins]

On Linux 2001-07-24-05 0.9.2 Branch in New Modern, I also see this in the knock
knockdialogs  "block" button  for IM

Comment 19

[Alexandru Savulov]

moving to 0.9.4

Comment 20

[Colin Phillips]

Where is the twips-to-pixels calculation being done?  I'd like to see if there
is some obvious error in the algorithm somewhere.

Comment 21

[Joe Hewitt (gone)]

*** Bug 89426 has been marked as a duplicate of this bug. ***

Comment 22

[Alexandru Savulov]

pushing to 0.9.5

Comment 23

[Joe Hewitt (gone)]

*** Bug 98390 has been marked as a duplicate of this bug. ***

Comment 24

[Alexandru Savulov]

removed target milestone

Comment 25

[Joe Hewitt (gone)]

*** Bug 106367 has been marked as a duplicate of this bug. ***

Comment 26

[Lev Iserovich]

Is this related to bug #80530? 
<a href="http://bugzilla.mozilla.org/show_bug.cgi?id=80530">80530</a>

Comment 27

[Alexandru Savulov]

future

Comment 28

[Julien Cegarra]

WFM (buildID: 2002072204).
Could we close this one now ?

/jc

Comment 29

[Ashley Bischoff (blog at handcoding.com)]

WFM 2002072608 on Win2k. 

Reporter: Are you still seeing this bug?

Comment 30

[Skewer]

See comment 11 for my experience.

Comment 31

[Christopher Hoess (gone)]

WFM. Resolving so.