791149 - startup crash in [@ nsParseMailMessageState::FinalizeHeaders()]

Status: RESOLVED WORKSFORME

(MailNews Core :: Backend, defect)

Description

[Wayne Mery (:wsmwk)]

This bug was filed from the Socorro interface and is 
report bp-c5fceb39-3e48-45e3-ac3c-d5a862120813 .
============================================================= 

Frame	Module	Signature	Source
0	msvcr80.dll	strlen	F:\dd\vctools\crt_bld\SELF_X86\crt\src\intel\strlen.asm:69
1	xul.dll	nsParseMailMessageState::FinalizeHeaders	mailnews/local/src/nsParseMailbox.cpp:1346
2	xul.dll	nsParseMailMessageState::ParseFolderLine	mailnews/local/src/nsParseMailbox.cpp:711
3	xul.dll	nsMsgMailboxParser::HandleLine	mailnews/local/src/nsParseMailbox.cpp:526
4	xul.dll	nsPop3Sink::WriteLineToMailbox	mailnews/local/src/nsPop3Sink.cpp:750
5	xul.dll	nsPop3Sink::IncorporateWrite	mailnews/local/src/nsPop3Sink.cpp:737
6	xul.dll	nsPop3Protocol::HandleLine	mailnews/local/src/nsPop3Protocol.cpp:3636
7	xul.dll	nsPop3Protocol::RetrResponse	mailnews/local/src/nsPop3Protocol.cpp:3396
8	xul.dll	nsPop3Protocol::ProcessProtocolState	mailnews/local/src/nsPop3Protocol.cpp:4021
9	xul.dll	nsMsgProtocol::OnDataAvailable	mailnews/base/util/nsMsgProtocol.cpp:389
10	xul.dll	nsInputStreamPump::OnStateTransfer	netwerk/base/src/nsInputStreamPump.cpp:518

Comment 1

[:aceman]

Another couple of functions returning int instead of nsresult...

But I can't see the reason for the crash. Is this a single occurrence of this signature?

Comment 2

[Wayne Mery (:wsmwk)]

it is rare - about 8 per month, so there are multiple examples - https://crash-stats.mozilla.com/query/query?product=Thunderbird&version=ALL%3AALL&date=&range_value=4&range_unit=weeks&query_search=signature&query_type=exact&build_id=&process_type=all&do_query=1&query=nsParseMailMessageState%3A%3AFinalizeHeaders%28%29

and for all releases
bp-a92e9062-9af8-4777-8aa8-5869d2120625 tb3.1.20
bp-2dfe8f08-a1dc-4666-87b2-350e02120723 tb13.0
bp-6c119dfb-802d-4da8-944d-29fae2120807 tb14.0

high percentage are startup crashes

Comment 3

[Wayne Mery (:wsmwk)]

(partly in followup to bug 877831 comment 14)

Hiro had a patch in Bug #877831, fixed in TB 24.0.1 or 24.0.2? ...

bug we still have this startup crashes:
bp-94460041-e6e6-425f-b6cd-d98842140723 TB31.0
bp-0723a2fb-0ba4-4b39-a641-5ed772140801 TB31.0 linux
bp-d1a459b6-20c5-48b2-ab42-8dc152140717 TB24.6.0
bp-b8832e62-f6a3-409d-aefe-9ecc52140805 TB24.6.0

Non-startup crashes are covered in bug 1051616 - but I don't know for a fact that any of them are different than the crashes cited in this bug.

hiro do you want to continue your great work here?

Comment 4

[Ludovic Hirlimann [:Usul]]

Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to :aceman from comment #1)
> Another couple of functions returning int instead of nsresult...
> 
> But I can't see the reason for the crash. Is this a single occurrence of
> this signature?

see bug 1051616

Comment 6

[Wayne Mery (:wsmwk)]

no crashes for >2 months strlen | nsParseMailMessageState::FinalizeHeaders

only 6 crashes for nsParseMailMessageState::FinalizeHeaders, all 52.5.2. I think only bp-e24ad70e-d067-4e68-bf20-57b200180108 has s decent stack.  None are startup, so they are all of the flavor of bug 1051616.

No crashes since Feb 1, and no crashes in 52.6.0.