791273 - nsSuiteGlue does unnecessary work when there are no new add-ons installed (Port Bug 727637).

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

From Bug 727637 Comment 0:

> In nsBrowserGlue, _onWindowsRestored checks for newly installed addons - if there are 
> any then it opens tabs for about:newaddon. However, if there are *not* any new addons, 
> then it still unnecessary uses the Add-ons Manager API to fetch data for an empty list 
> of addons.

The Firefox patch is here:
https://hg.mozilla.org/mozilla-central/rev/e4901b5d891a

Our equivalent file is nsSuiteGlue.js:
http://mxr.mozilla.org/comm-central/source/suite/common/src/nsSuiteGlue.js

And the part to change is here:
http://mxr.mozilla.org/comm-central/source/suite/common/src/nsSuiteGlue.js?rev=9e6f4b466746&mark=324-334#317

Comment 1

[Edmund Wong (:ewong)]

Attachment: Ignore processing if list of changed add-ons is zero. (v1)

Comment 2

[Philip Chee]

Comment on attachment 687353 [details] [diff] [review]
Ignore processing if list of changed add-ons is zero. (v1)

You might want to change the AddonManager.jsm import to a LazyModuleGetter like in the Firefox patch:

https://hg.mozilla.org/mozilla-central/rev/e4901b5d891a#l1.18

> +XPCOMUtils.defineLazyModuleGetter(this, "AddonManager",
> +                                  "resource://gre/modules/AddonManager.jsm");

> +    if (changedIDs.length > 0) {
Just use:
  if (changedIDs.length) {

Comment 3

[Edmund Wong (:ewong)]

Attachment: Ignore processing if list of changed add-ons is zero. (v2)

Comment 4

[Edmund Wong (:ewong)]

Attachment: Ignore processing if list of changed add-ons is zero. (v3)

Comment 5

[[e-mail]]

Comment on attachment 687665 [details] [diff] [review]
Ignore processing if list of changed add-ons is zero. (v3)

I thought AddonManager was in the startup path anyway (navigator.js loads it for instance) but I guess it won't hurt. r=me based on looking at a -w diff.

Comment 6

[Philip Chee]

Comment on attachment 687665 [details] [diff] [review]
Ignore processing if list of changed add-ons is zero. (v3)

> +XPCOMUtils.defineLazyModuleGetter(this, "AddonManager",
> +                                  "resource//gre/modules/AddonManager.jsm");
I don't know why but changing the import() to a LazyModuleGetter stops the code from working. r=me if you revert this change back to:

Components.utils.import("resource://gre/modules/AddonManager.jsm");

Comment 7

[Edmund Wong (:ewong)]

Attachment: Ignore processing if list of changed add-ons is zero. (v4)

Comment 8

[Edmund Wong (:ewong)]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/fde7ce3d8e53