791669 - [New Tab Page] don't immediately preload the new tab page on startup

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

After delayed startup, we should wait for a couple of seconds (like the download manager does before resuming) until we start preloading new tab pages in the background. This feature must not interfere with startup times.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 662564 [details] [diff] [review]
patch v1

Review of attachment 662564 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nit addressed.

Thanks for fixing this. Hopefully this is the last remaining piece before we can enable the preload pref.

::: browser/modules/BrowserNewTabPreloader.jsm
@@ +58,5 @@
> +    }
> +  },
> +
> +  observe: function Initializer_observe(aSubject, aTopic, aData) {
> +    if (aTopic == "browser-delayed-startup-finished") {

if (aTopic == TOPIC_DELAYED_STARTUP) {

Comment 3

[:Gavin Sharp [email: [e-mail]]]

A hardcoded 5s timer is a bit gross, can we file a followup to use some better mechanism (perhaps dependent on bug 712478)?

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #3)
> A hardcoded 5s timer is a bit gross, can we file a followup to use some
> better mechanism (perhaps dependent on bug 712478)?

Yeah I didn't like that too much either but I think we don't have a real alternative at the moment. The download panel does the same with a 10s timer to resume previous downloads. I'll file a follow-up but I'm not sure if bug 712478 can help us with that. Wouldn't we need some event/notification that tells us when user is *not* doing something? Or when the browser has finished doing the important stuff after startup?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/9c75ed3092e8

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/9c75ed3092e8